fix(roadmap): handle 5-column progress tables with Milestone column#923
Open
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Open
fix(roadmap): handle 5-column progress tables with Milestone column#923j2h4u wants to merge 1 commit intogsd-build:mainfrom
j2h4u wants to merge 1 commit intogsd-build:mainfrom
Conversation
The regex-based table parser captured a fixed number of columns,
so 5-column tables (Phase | Milestone | Plans | Status | Completed)
had the Milestone column eaten and Status/Date written to wrong cells.
Replaced regex with cell-based `split('|')` parsing that detects
column count (4 or 5) and updates the correct cells by index.
Affects both `cmdRoadmapUpdatePlanProgress` and `cmdPhaseComplete`.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaced regex-based progress table parsing with cell-based
split('|')approach in bothcmdRoadmapUpdatePlanProgressandcmdPhaseComplete. Now correctly handles both 4-column and 5-column (with Milestone) table layouts.Why
The regex captured a fixed number of columns, so 5-column tables (
Phase | Milestone | Plans | Status | Completed) had the Milestone column consumed by the match — Status and Date were written to the wrong cells, corrupting the table.Testing
Checklist
Breaking Changes
None